Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-codes in-page links unnecessarily #249

Closed
michael-n-cooper opened this issue Jul 26, 2013 · 5 comments
Closed

Hard-codes in-page links unnecessarily #249

michael-n-cooper opened this issue Jul 26, 2013 · 5 comments

Comments

@michael-n-cooper
Copy link
Member

Respec changes in-page links to hard-coded URIs by concatenating the doc's current URI with the in-page link. E.g., <a href="#foo"> becomes <a href="http://www.example.com/myuri/#foo"> This seems unnecessary and creates a few problems. First, I stage documents from a different location than the final publication location, so the URI it inserts is wrong and has to be replaced. Second, these absolute URIs make it harder for someone to download the doc for offline reading and follow internal links easily, and similar use cases. The absolute URIs have no value-add I know of and request that in-page links be left alone.

@tobie
Copy link
Member

tobie commented Jul 26, 2013

Which browser are you using?

@michael-n-cooper
Copy link
Member Author

Firefox 19. I didn't think that would be relevant to this behaviour or I would have included it in the bug report, as I did with some other bugs.

@tobie
Copy link
Member

tobie commented Jul 26, 2013

Turning relative urls into absolute ones is a known issue when using innerHTML with some versions of IE. Sounds like this isn't the issue, though.

@halindrome
Copy link
Contributor

I do not see this happening either live nor when saving static versions. Can you provide a small test example?

@darobin
Copy link
Member

darobin commented Dec 23, 2014

@michael-n-cooper It looks like @halindrome couldn't reproduce this, and neither can I. I'm closing this issue for now; if you have an example of the behaviour please reopen with a link!

@darobin darobin closed this as completed Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants