Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop promisify() from tests #3188

Closed
saschanaz opened this issue Oct 30, 2020 · 2 comments · Fixed by #3330
Closed

Drop promisify() from tests #3188

saschanaz opened this issue Oct 30, 2020 · 2 comments · Fixed by #3330
Labels
good first issue These bug should be easy for anyone getting started refactoring

Comments

@saschanaz
Copy link
Member

fs.promises API has been there for a while. We should be able to use it without breaking changes.
@sidvishnoi sidvishnoi added refactoring good first issue These bug should be easy for anyone getting started labels Oct 30, 2020
@uditmishra128
Copy link

Hi ,I would like to work on this issue , can you suggest me way to get started.

@sidvishnoi
Copy link
Member

sidvishnoi commented Feb 9, 2021 •
edited

@uditmishra128 We want to replace promisify calls in tests/test-build.js (and other files if any) with the fs.promises API. The tests are run via npm run test:build.

@marcoscaceres marcoscaceres mentioned this issue Feb 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue These bug should be easy for anyone getting started refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(tests/test-build): use fs.promises instead of promisify w3c/respec
3 participants
@saschanaz @sidvishnoi @uditmishra128