Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS for DL requires <section class='section'> #366

Closed
ddorwin opened this issue Dec 5, 2014 · 3 comments
Closed

CSS for DL requires <section class='section'> #366

ddorwin opened this issue Dec 5, 2014 · 3 comments
Milestone

Comments

@ddorwin
Copy link

ddorwin commented Dec 5, 2014

The following CSS does not get applied unless the class 'section' is added to <section>s that that contain <dl>s. It should be applied to all <section>s.

/* --- DL --- */
.section dd > p:first-child {
margin-top: 0;
}
.section dd > p:last-child {
margin-bottom: 0;
}
.section dd {
margin-bottom: 1em;
}
.section dl.attrs dd, .section dl.eldef dd {
margin-bottom: 0;
}

Robin says this looks like some code that remains from when <section> had to be converted into <div class=section>.

@halindrome
Copy link
Contributor

I am guessing that you had some markup in there that was eaten, and the markup was about elements named section and maybe div? Can you just clarify so I am certain what needs to be fixed?

@ddorwin
Copy link
Author

ddorwin commented Dec 10, 2014

Sorry about that. I fixed the original report.

The fix may be as simple as deleting the period before "section". I'm not sure if there is any importance to the dl or dd elements being in a section element, though.

@darobin
Copy link
Member

darobin commented Dec 10, 2014

There is: it distinguishes them from the the DL at the top of the boilerplate.

@darobin darobin modified the milestone: 3.2 Dec 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants