Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msg should only be included as needed. #746

Closed
marcoscaceres opened this issue May 9, 2016 · 1 comment
Closed

msg should only be included as needed. #746

marcoscaceres opened this issue May 9, 2016 · 1 comment
Milestone

Comments

@marcoscaceres
Copy link
Member

marcoscaceres commented May 9, 2016

ReSpec code is littered with code like this:

        var done = function() {
          msg.pub("end", "core/highlight");
          cb();
        };

The above should be a curried function provided by the utils object.

like:

utils.makeDone(moduleName){
   return (cb) => {
       return (msg) => {
             msg.pub("end", moduleName);
             cb();
       }
   }
}

Then all modules should get the messages as needed, not as an argument on run.

Start and stop messages on trace is a pretty crude way to do debugging.

@marcoscaceres marcoscaceres added this to the v4 milestone May 9, 2016
@marcoscaceres
Copy link
Member Author

Got rid of most of these, except some remain for backwards compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant