Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The orientation type 'Natural' should only lock to x-primary #83

Closed
hexalys opened this issue Dec 4, 2014 · 2 comments
Closed

The orientation type 'Natural' should only lock to x-primary #83

hexalys opened this issue Dec 4, 2014 · 2 comments

Comments

@hexalys
Copy link

hexalys commented Dec 4, 2014

The following definition has contradictions, leading to confusion as to what is natural:

natural: Append portrait-primary, portrait-secondary, landscape-primary or landscape-secondary to orientations such as the associated screen orientation angle is 0.

The angle shall never be 0 on a -secondary position. The point of natural is to be a unique 0 angle opposite of a 180 reverse angle. Allowing an implementation to lock to natural to x-secondary would reduce natural to an orientation as opposed to an angle.

It should definitely not be the same as any. A platform convention is most likely to append natural with an 'any' lock anyway. Most importantly, the angle relationship with portrait-primary, portrait-secondary, landscape-primary or landscape-secondary cannot change arbitrarily during runtime.

Also how about adding a current orientation lock.

@hexalys
Copy link
Author

hexalys commented Feb 12, 2015

@mounirlamouri Any review of this issue yet? Instead it should be:

natural: Append portrait-primary or landscape-primary to orientations such as the associated screen orientation angle is 0.

@mounirlamouri
Copy link
Member

Thanks for the report @hexalys and sorry for taking so long to reply. PR #84 is fixing this. Feel free to leave a comment there if it doesn't match what you were expecting.

mounirlamouri added a commit that referenced this issue Mar 26, 2015
Natural shouldn't be equivalent to *-secondary. Fixes #83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants