Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release() linking to wrong algorithm? #271

Closed
jakearchibald opened this issue Aug 17, 2020 · 0 comments · Fixed by #275
Closed

release() linking to wrong algorithm? #271

jakearchibald opened this issue Aug 17, 2020 · 0 comments · Fixed by #275

Comments

@jakearchibald
Copy link

screen-wake-lock/index.html

Line 456 in 699adb0

<li>Run <a>release wake lock</a> with |lock:WakeLockSentinel| set

Seems like this is pointing to the wrong thing. Right now it doesn't seem to result in anything useful happening.
rakuco added a commit to rakuco/wake-lock that referenced this issue Aug 17, 2020
@rakuco
Reference the "release a wake lock" algorithm in WakeLockSentinel.rel…
4ec6655 
…ease()

We were referring to the "release wake lock" definition instead, which did
not make much sense in this context.

Fixes w3c#271.
@rakuco rakuco mentioned this issue Aug 17, 2020
Merged
rakuco added a commit that referenced this issue Aug 17, 2020
@rakuco
Reference the "release a wake lock" algorithm in WakeLockSentinel.rel…
7a05206 
…ease()

We were referring to the "release wake lock" definition instead, which did
not make much sense in this context.

Fixes #271.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reference the "release a wake lock" algorithm in WakeLockSentinel.release() rakuco/wake-lock
1 participant
@jakearchibald