Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editorial: Reword the Security and Privacy Considerations section. #287

Merged
merged 2 commits into from Sep 23, 2020
Merged

editorial: Reword the Security and Privacy Considerations section. #287

merged 2 commits into from Sep 23, 2020

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Sep 19, 2020 •
edited by pr-preview bot

Incorporate feedback from #286, where @marcosc proposed a few changes to the
part of the paragraph that had been copied from the spec:

I think say "and potentially dangerous" is going a bit overboard, tbh.
Browsers are just tapping into publicly available OS APIs to provide this
functionality (not arbitrary hacks that could cause a screen or device to
catch on fire) - and those are hardly dangerous.

Preview | Diff

@rakuco rakuco mentioned this pull request Sep 19, 2020
Merged
marcoscaceres
marcoscaceres reviewed Sep 23, 2020
View reviewed changes
index.html Outdated Show resolved Hide resolved
marcoscaceres
marcoscaceres approved these changes Sep 23, 2020
View reviewed changes
Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit on the wording... iOS allows me to set the phone to "low power mode" manually, so it might be prudent to mention that it's really something that the user is in control of.

@rakuco
editorial: Reword the Security and Privacy Considerations section.
1d73afe 
Incorporate feedback from w3c#286, where @marcosc proposed a few changes to the
part of the paragraph that had been copied from the spec:

> I think say "and potentially dangerous" is going a bit overboard, tbh.
> Browsers are just tapping into publicly available OS APIs to provide this
> functionality (not arbitrary hacks that could cause a screen or device to
> catch on fire) - and those are hardly dangerous.
@rakuco
Incorporate Marcos' suggestion.
cec0576
@rakuco rakuco force-pushed the editorial/reword-security-section branch from 93e56e9 to cec0576 Compare September 23, 2020 09:39
@rakuco
Copy link
Member Author

rakuco commented Sep 23, 2020

Thanks, I've incorporate your suggestion. AFAICS has a similar battery-saving option that users can activate too.

@rakuco rakuco merged commit 0b715f7 into w3c:gh-pages Sep 23, 2020
@rakuco rakuco deleted the editorial/reword-security-section branch September 23, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcoscaceres marcoscaceres marcoscaceres approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rakuco @marcoscaceres