workflows/tidy: Run on ubuntu-20.04. #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch from macos-latest to ubuntu-20.04. There should be no user-visible changes, but running on Linux makes it easier to test and understand.
marcoscaceres
approved these changes
Jun 2, 2021
rakuco
added a commit
to rakuco/wake-lock
that referenced
this pull request
Jun 2, 2021
This reverts commit b6b4742. The tidy 5.6.0 package shipped in Debian (up to bullseye at the time of writing) as well as Ubuntu (up to 21.04 at least) is built with a patch that causes the configurations settings we pass via `-config .tidyrc` to be ignored when running (0011-Revert-Remove-unnecessary-AdjustConfig-logic.patch). The easiest fix is to just revert the commit and continue running tidy on macos-latest for the time being.
marcoscaceres
pushed a commit
that referenced
this pull request
Jun 3, 2021
|
@rakuco, sorry to ping you on a totally unrelated bug, but the "[=now visible algorithm=]" ReSpec bug has been fixed... I can't remember where you pinged me about that, but you can now link to it! If you find that bug again, let me know. |
|
Thanks, I originally asked about it in w3c/page-visibility#47. I actually need the "external now hidden algorithm", w3c/page-visibility#72 should make it possible to reference it from this spec. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from macos-latest to ubuntu-20.04. There should be no user-visible
changes, but running on Linux makes it easier to test and understand.