Remove permission check #366
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoscaceres
force-pushed
the
permissions
branch
from
71a6c31
to
4023312
Compare
marcoscaceres
commented
Dec 18, 2023
| @@ -327,81 +269,43 @@ <h3> | |||
| |document|, return [=a promise rejected with=] a | |||
| {{"NotAllowedError"}} {{DOMException}}. | |||
| </li> | |||
| <li data-tests="wakelock-active-document.https.window.html">If | |||
There was a problem hiding this comment.
Moved this to #367 ... should be done first
reillyeon
requested changes
Apr 9, 2024
index.html
Outdated
Comment on lines
276
to
279
| <li>If |document|'s [=Document/visibility state=] is "hidden", then | ||
| return [=a promise rejected with=] with a {{"NotAllowedError"}} | ||
| {{DOMException}}. | ||
| </li> |
There was a problem hiding this comment.
Remove this. It looks like it got duplicated during a merge.
| <ol> | ||
| <li>Set |lock|'s {{WakeLockSentinel/[[Released]]}} to `true`. | ||
| </li> | ||
| <li>[=Fire an event=] named "`release`" at |lock|. |
There was a problem hiding this comment.
An event is already fired at the end of these steps. I think moving this into a task on the screen wake lock task source is the right move but it's probably best to just wrap all the steps in that since they're manipulating properties of the document.
Co-authored-by: Reilly Grant <reillyeon@users.noreply.github.com>
marcoscaceres
commented
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just picking this up again...
Closes #324
The following tasks have been completed:
Implementation commitment:
Preview | Diff