Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up automatic testing #8

Closed
tripu opened this issue Jun 14, 2017 · 3 comments
Closed

Set up automatic testing #8

tripu opened this issue Jun 14, 2017 · 3 comments

Comments

@tripu
Copy link
Member

tripu commented Jun 14, 2017

A comprehensive test suite would be ideal, of course.

But for now, we can make do with the simplest test: feed scribejs a minimal, fixed IRC log, and check that there's an output and that the output contains certain expected strings.

Test it both as a CLI tool and as a CGI script, if feasible.

That'd allow us to use Travis CI and have it running this test automatically for each new commit or PR, which is useful to quickly identify critical bugs, of the kind that completely break the tool.

@iherman
Copy link
Member

iherman commented Jun 15, 2017

There is indeed no systematic test suite; I have tested it via existing irc logs and I used it for the various groups I work with the past few days. When some error occurred, I used the real life irc logs to chase down the problem.

Some test irc logs and configuration files are present in the test folder. For example, the command

scribejs -c test/config.json test/poe-test.txt

(Run at the top level, that is) 'rocks' the script in many respect. And there are some other txt files in the same directory that should produce proper results, too. I am not sure how to set up travis, though.

@tripu
Copy link
Member Author

tripu commented Jun 15, 2017

Good thing there are sample files already.

I'll explain to you how to automate this, or I will submit a PR myself, @iherman.

@iherman
Copy link
Member

iherman commented Jun 15, 2017 via email

@tripu tripu self-assigned this Jul 6, 2017
tripu added a commit that referenced this issue Jul 6, 2017
tripu added a commit that referenced this issue Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants