Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add observationType and hasQualityMeasurement #119

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Add observationType and hasQualityMeasurement #119

merged 8 commits into from
Dec 5, 2023

Conversation

dr-shorthair
Copy link
Collaborator

Additional Observation properties mentioned in OMS

@dr-shorthair dr-shorthair mentioned this pull request Nov 17, 2023
Closed
KathiSchleidt
KathiSchleidt approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@KathiSchleidt KathiSchleidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dr-shorthair dr-shorthair mentioned this pull request Nov 27, 2023
Closed
@maximelefrancois86 maximelefrancois86 self-assigned this Nov 30, 2023
maximelefrancois86
maximelefrancois86 requested changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@maximelefrancois86 maximelefrancois86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is observationType in the SOSA namespace ? This object property is not defined in sosa.ttl and not documented in the specification.

@dr-shorthair
Copy link
Collaborator Author

dr-shorthair commented Dec 1, 2023 •
edited

It comes from OMS.
I put it in sosa: ns in anticipation of it being added to sosa.ttl.
See #132

@dr-shorthair
Copy link
Collaborator Author

My suggestion is that we put all the new things in sosa: provisionally.
We can then consider if we need more horizontal modules in due course, which might involve moving some terms into new namespaces.

(We have a lot of branches and need to do some merging soon else it'll get horribly tangled.)

@dr-shorthair
Copy link
Collaborator Author

Closes #124

sgrellet
sgrellet approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@sgrellet sgrellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me

@dr-shorthair
Copy link
Collaborator Author

Why is observationType in the SOSA namespace ? This object property is not defined in sosa.ttl and not documented in the specification.

For clarity at this stage, I've moved all the terms that are defined in the SOSA-OMS graph into the sosa-oms: ns.
We can consider the final destination in #132.
@maximelefrancois86 can you approve now so we can merge?

@dr-shorthair dr-shorthair merged commit b4250dc into gh-pages Dec 5, 2023
1 check passed
@dr-shorthair dr-shorthair mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximelefrancois86 maximelefrancois86 maximelefrancois86 approved these changes

@KathiSchleidt KathiSchleidt KathiSchleidt approved these changes

@sgrellet sgrellet sgrellet approved these changes

@rob-metalinkage rob-metalinkage Awaiting requested review from rob-metalinkage

Assignees

@maximelefrancois86 maximelefrancois86

Labels
sosa-oms-alignment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dr-shorthair @maximelefrancois86 @KathiSchleidt @sgrellet