Implemented first set of comments by Markus Stocker #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssn/index.html
Outdated
| @@ -1571,7 +1567,7 @@ <h3 id="horizontal-segmentation">Horizontal Segmentation</h3> | |||
| <span property="skos:example">Dividing a field site into quadrants.</span><br> | |||
| <span property="skos:example">Drawing blood from a patient.</span><br> | |||
| <span property="skos:example">Drilling an observation well.</span><br> | |||
| <span property="skos:example">Establishing a station for environmental monitoring.</span><br> | |||
| <span property="skos:example">Environmental monitoring.</span><br> | |||
There was a problem hiding this comment.
No - don't accept this change. 'Sampling' in this case corresponds with the process of siting and establishing a monitoring station - the result is a new monitoring station. 'Environmental Montoring' results in a new time-series (that comes later).
ssn/integrated/sosa.ttl
Outdated
| @@ -312,7 +312,7 @@ sosa:Sampling a rdfs:Class , owl:Class ; | |||
| skos:example "Dividing a field site into quadrants."@en ; | |||
| skos:example "Drawing blood from a patient."@en ; | |||
| skos:example "Drilling an observation well."@en ; | |||
| skos:example "Establishing a station for environmental monitoring."@en ; | |||
| skos:example "Environmental monitoring."@en ; | |||
|
I added comments in two places, where I think the change should be rejected. "Establishing a station for environmental monitoring." should stay. |
dr-shorthair
requested changes
May 17, 2017
|
BTW - what a sensational review. |
|
Yes, we need to thank him!
…On 05/16/2017 11:00 PM, Simon Cox wrote:
BTW - what a sensational review.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#894 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABrH9vOFwpkNb3I1jkQR0ymni3rsm4Olks5r6ozngaJpZM4NdYGp>.
--
Krzysztof Janowicz
Geography Department, University of California, Santa Barbara
4830 Ellison Hall, Santa Barbara, CA 93106-4060
Email: jano@geog.ucsb.edu
Webpage: http://geog.ucsb.edu/~jano/
Semantic Web Journal: http://www.semantic-web-journal.net
|
dr-shorthair
approved these changes
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.