Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated figures to solve ISSUE-198 #905

Merged
merged 7 commits into from
Jun 14, 2017
Merged

Updated figures to solve ISSUE-198 #905

merged 7 commits into from
Jun 14, 2017

Conversation

rgcmme
Copy link
Contributor

@rgcmme rgcmme commented May 31, 2017

Updated figures to solve ISSUE-198.

@maximelefrancois86
Copy link
Contributor

hi, I don't agree with this public comment and the update you propose to make altogether:

Observation/Actuation/Sampling are all activities. It's ok to use just thoses.

on the other hand, Sensing is not a concept in SOSA/SSN anymore.

Plus, if we name the central rectangle Sensing/Observation/Actuation/Sampling, people may get confused and think that this is exactly what the SOSA core is. But it isn't: concept Platform and Result are in SOSA but not in this central rectangle for example.

I suggest we just answer the comment and close the issue without any further modification.

@rgcmme
Copy link
Contributor Author

rgcmme commented May 31, 2017

No problem from my part on not changing this. I did it due to a request from @arminhaller and I have to take a plane in a couple of hours.

@maximelefrancois86
Copy link
Contributor

ok, let's wait for the other's comment then. Travel safe.

@kjano
Copy link
Contributor

kjano commented May 31, 2017

Figures 3 and 4 also still lack Actuator and Sample related classes in the overview. Wrt Sensing; yes, see the change note "Removed ssn:Sensing Class". The class does not exist anymore.

@arminhaller
Copy link
Contributor

I was probably unclear in my email to Raul which I wrote in a rush. It was actually referring to https://www.w3.org/2015/spatial/track/issues/198 and the Sensing/Actuating pattern issue that was raised in emails. The latter we may just ignore, now that we don't have the Sensing Class, but we could also just rename the box into Sensing/Actuating/Sampling, or leave it as it is. But we just need to show that we have addressed the comments we got in the review.

@arminhaller arminhaller added the ssn label Jun 6, 2017
@rgcmme
Copy link
Contributor Author

rgcmme commented Jun 7, 2017

With regards to ISSUE-198, I will name the box "Observation/Actuation/Sampling".

Regarding figures 3 and 4, I just presented the perspective of the Observation because adding more classes there would be a bit of a mess.

Figure 4, for example, is already full of boxes and arrows. Adding more of them will not make anything understandable.

However, I see why you want those classes to appear there. What do you think of producing 3 versions of figures 3 and 4 as follows?

  • Figure 3 Overview of the SOSA classes and properties (observation perspective)
  • Figure 4 Overview of the SSN classes and properties (observation perspective)
  • Figure 5 Overview of the SOSA classes and properties (actuation perspective)
  • Figure 6 Overview of the SSN classes and properties (actuation perspective)
  • Figure 7 Overview of the SOSA classes and properties (sampling perspective)
  • Figure 8 Overview of the SSN classes and properties (sampling perspective)

@rgcmme
Copy link
Contributor Author

rgcmme commented Jun 7, 2017

I have implemented the changes as described above. Please, take a look at them.

@dr-shorthair
Copy link
Collaborator

The figures look nice to me.

@arminhaller
Copy link
Contributor

Figures look nice!

@arminhaller
Copy link
Contributor

BTW, can you please add a line to the change history indicating that you added the figures?

@rgcmme
Copy link
Contributor Author

rgcmme commented Jun 13, 2017

Change history updated!

@rgcmme
Copy link
Contributor Author

rgcmme commented Jun 14, 2017

Figure 3 has turned into figures 3, 5 and 7 to show the observation, actuation and sampling perspectives.
Similarly, figure 4 has turned into figures 4, 6 and 8.
It was quite impossible to put everything together in a meaningful figure.

@arminhaller arminhaller merged commit 42ba1cd into w3c:gh-pages Jun 14, 2017
@kjano
Copy link
Contributor

kjano commented Jun 16, 2017 via email

@dr-shorthair
Copy link
Collaborator

dr-shorthair commented Jun 18, 2017 via email

@rgcmme
Copy link
Contributor Author

rgcmme commented Jun 19, 2017

Having everything in SOSA in a single slide can be a mess; there are plenty of terms reused for observation/actuation/sampling. Options are: not to show all the terms and only a subset or show the three views in parallel (or a mix of both as in Simon's slides).
I have uploaded the sources of the figures: #933
If anyone has a good idea for showing everything together, feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminhaller arminhaller Awaiting requested review from arminhaller

Assignees
No one assigned
Labels
ssn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rgcmme @maximelefrancois86 @kjano @arminhaller @dr-shorthair