Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples in Figure 1 & 2, change example in Figure 3 #28

Closed
wants to merge 4 commits into from
Closed

Fix examples in Figure 1 & 2, change example in Figure 3 #28

wants to merge 4 commits into from

Conversation

bact
Copy link
Contributor

@bact bact commented Nov 25, 2019

  • Fix wrong word boundary in Figure 1
    • ทั้งวิ|ทยาการ -> ทั้ง|วิทยาการ
  • Fix typo in Figure 2
    • "เข้ยน" -> "เขียน"
  • Propose a change of example in Figure 3
    • from "ผู้เชี่ย" (1) to "พรุ่งนี้" (2).
    • The word in (1) does not have meaning, and "เชี่ย" can be a rude word.
    • Changed to (2) which should be enough to illustrate combining characters above and below base characters. (2) means "tomorrow".

Propose a change from "ผู้เชี่ย" (1) to "พรุ่งนี้" (2).

The word in (1) does not have meaning, and "เชี่ย" can be a rude word.
Changed to (2) which should be enough to illustrate combining characters above and below base characters.

(2) means "tomorrow".
@p16i
Copy link

p16i commented Nov 26, 2019

Maybe we should also update these two examples?

image

- Fix wrong boundary in Figure 1
- Fix typo in Figure 2
@bact bact changed the title Change example in Figure 3 Fix examples in Figure 1 & 2, change example in Figure 3 Nov 26, 2019
@bact
Copy link
Contributor Author

bact commented Nov 27, 2019

@heytitle thanks. Updated them accordingly.

@bact bact requested a review from r12a January 27, 2020 16:47
@r12a
Copy link
Contributor

r12a commented Jan 27, 2020

@bact Many thanks for these fixes, and apologies for making some sloppy typos when creating the text. Before i can merge this PR, however, i need to check a couple of things with you offline. Could you send an email to ishida@w3.org so i can contact you?

+heytitle
also contribute to Figure 1 and 2 fixes
@r12a
Copy link
Contributor

r12a commented Jan 29, 2020

@bact could you undo the last commit? Adding a large number of format changes obscures the important changes to the document, so we have a rule to keep substantive changes separate from purely formatting changes. Thanks.

@bact
Copy link
Contributor Author

bact commented Jan 29, 2020

@bact could you undo the last commit? Adding a large number of format changes obscures the important changes to the document, so we have a rule to keep substantive changes separate from purely formatting changes. Thanks.

Sorry about that. Undo it already.

The main changes are in the (new) lines: 120, 125, 126, and 180.

@r12a
Copy link
Contributor

r12a commented Jan 31, 2020

@bact the cleanup didn't seem to work, so i created another PR myself at #29 with your proposed changes. I'll therefore close this PR. It would be good if you can find a way to turn off the autoformatting for your editor (at least while making PRs). Apart from the fact that lots of irrelevant format changes cause problems for review, autoformatting may occasionally remove formatting that is desired but not standard.

Thanks anyway for spotting and proposing corrections for these items!

@r12a r12a closed this Jan 31, 2020
@bact
Copy link
Contributor Author

bact commented Jan 31, 2020

Thank you.

@bact bact deleted the patch-1 branch January 31, 2020 14:48
Copy link
Contributor

@r12a r12a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants