Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of locale member #226

Closed
aphillips opened this issue Jan 28, 2023 · 3 comments
Closed

Example of locale member #226

aphillips opened this issue Jan 28, 2023 · 3 comments
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.

Comments

@aphillips
Copy link

1.2.2. Authentication on merchant site
https://w3c.github.io/secure-payment-confirmation/#authentication-example

 data: {
    // List of credential IDs obtained from the bank.
    credentialIds,

    rpId: "fancybank.com",

    // The challenge is also obtained from the bank.
    challenge: new Uint8Array([21,31,105 /* 29 more random bytes generated by the bank */]),

    instrument: {
      displayName: "Fancy Card ****1234",
      icon: "https://fancybank.com/card-art.png",
    },

    payeeName: "Merchant Shop",
    payeeOrigin: "https://merchant.com",

    timeout: 360000,  // 6 minutes
  }], {
    total: {
      label: "Total",
      amount: {
        currency: "USD",
        value: "5.00",
      },
    },
  });

Example 2 (linked above) shows the use of a secure payment confirmation request. The request structure is described in section 4.1.3 and includes a locale member for negotiating the locale of the response.

It would be useful to show this mechanism in the example, especially since the examples are all in English and somewhat U.S.-centric. It would be okay to show using en or en-US as the locale requested. Note that this is an editorial comment.

@aphillips aphillips added the i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on. label Jan 28, 2023
ianbjacobs added a commit that referenced this issue Jan 30, 2023
@ianbjacobs
Copy link
Collaborator

@aphillips, I believed this issue can be closed with the merge of pull request #229. Thanks!

@aphillips
Copy link
Author

LGTM!

@ianbjacobs
Copy link
Collaborator

Cool! You get to remove the label, cf recent thread! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n-needs-resolution Issue the Internationalization Group has raised and looks for a response on.
Projects
None yet
Development

No branches or pull requests

2 participants