Add payeeName input to spec #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenmcgruer
approved these changes
Mar 16, 2022
There was a problem hiding this comment.
LGTM % one nit; I think section 10.2 also needs updated to mention the name alongside the origin.
As usual, let's leave this for a week to let folks from the WPWG take a look and leave any feedback. I'll make sure its on the agenda for Thurs (cc @ianbjacobs ).
ianbjacobs
reviewed
Mar 16, 2022
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 16, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3
|
cc @tblachowicz |
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 18, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 18, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 18, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Mar 21, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 21, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 21, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464}
|
Thanks all, merging this one now! |
github-actions bot
added a commit
that referenced
this pull request
Mar 23, 2022
SHA: 654c78a Reason: push, by @nickburris Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 26, 2022
Automatic update from web-platform-tests [SPC] Add payeeName option Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464} -- wpt-commits: 573fa63f75bbaa6940a8bfe9cb30bc06a212aae4 wpt-pr: 33213
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 27, 2022
Automatic update from web-platform-tests [SPC] Add payeeName option Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464} -- wpt-commits: 573fa63f75bbaa6940a8bfe9cb30bc06a212aae4 wpt-pr: 33213
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Mar 28, 2022
Automatic update from web-platform-tests [SPC] Add payeeName option Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464} -- wpt-commits: 573fa63f75bbaa6940a8bfe9cb30bc06a212aae4 wpt-pr: 33213
aosmond
pushed a commit
to aosmond/gecko
that referenced
this pull request
Mar 28, 2022
Automatic update from web-platform-tests [SPC] Add payeeName option Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464} -- wpt-commits: 573fa63f75bbaa6940a8bfe9cb30bc06a212aae4 wpt-pr: 33213
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
Implementation for the recent spec change[1] to add a payeeName option as an optional alternative to payeeOrigin. The API now accepts one or both of payeeName and payeeOrigin. If both are provided, they are both shown in the UI with the format "payeeName (payeeOrigin)". This formatting when both fields are present is done in the UI code for two reasons; it's easier to test, and it can be considered a UI implementation detail how they are displayed, e.g. on a different platform or future iteration of the UI the origin could be displayed in a different font than the name, so the MVC model keeps them separate. [1] w3c/secure-payment-confirmation#180 Bug: 1298505 Change-Id: I19a255ce9f162b7d9e6c4cf0c2164242fa96cfc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3523272 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/main@{#983464} NOKEYCHECK=True GitOrigin-RevId: f0b1a99a6af801ce883d2076103fb34e6fb1f65c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the proposal in #163, add a payeeName field to the spec.
Preview | Diff