Make offset and allowPartialContainment arguments optional #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are already optional in Blink and WebKit. It's possible that it would be web compatible to make them required, but given that the methods still make some sense with these arguments optional, it doesn't seem worth risking any breakage at all to find out. Fixes w3c#30
rniwa
added a commit
that referenced
this pull request
Mar 1, 2016
Make offset and allowPartialContainment arguments optional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are already optional in Blink and WebKit. It's possible that it
would be web compatible to make them required, but given that the
methods still make some sense with these arguments optional, it doesn't
seem worth risking any breakage at all to find out.
Fixes #30