Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find an appropriate test reviewer #242

Closed
Honry opened this issue Jun 30, 2017 · 4 comments
Closed

Find an appropriate test reviewer #242

Honry opened this issue Jun 30, 2017 · 4 comments

Comments

@Honry
Copy link
Contributor

Honry commented Jun 30, 2017

First of all, many thanks @tobie for helping review tests for sensors, he may not be active on test review as he had stepped down as the editor.

In order to advance the test review process, we need another dedicated test reviewers. @pozdnyakov and @alexshalamov, I think you could be the best successors, are you happy to be the ones? Or any other volunteers?

BTW, the new process of test review in Web Platform Tests requires the reviewer should have the write access, it's troublesome that each time we have to ask for another people with write access to approve and merge the PR. Is that possible to grant dedicated reviewers with write access to Web Platform Tests? @anssiko

@anssiko
Copy link
Member

anssiko commented Jun 30, 2017

the new process of test review in Web Platform Tests requires the reviewer should have the write access

I'm not familiar with the new process, ping @jgraham.

@alexshalamov
Copy link

@Honry Sure, we can review tests when needed. We wrote quite extensive Chromium layout tests, and we can give an input for improvements of Generic Sensor web-platform-tests.

Just tag me and Mikhail when you need a review, meanwhile, we can figure out what to do with write access.

@Honry
Copy link
Contributor Author

Honry commented Jun 30, 2017

@alexshalamov, thank you so much for the support, I will add you and Mikhail to the OWNERS list then you can automatically receive the notification once there's new PR.

For the write access to Web Platform Tests, I was granted by @dontcallmedom, maybe he could help. Kindly ping @dontcallmedom.

@alexshalamov
Copy link

@dontcallmedom Thanks Dominique.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants