Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The internal slots are not reset #243

Closed
pozdnyakov opened this issue Jun 30, 2017 · 0 comments · Fixed by #197
Closed

The internal slots are not reset #243

pozdnyakov opened this issue Jun 30, 2017 · 0 comments · Fixed by #197
Assignees
@pozdnyakov
Milestone
Level 1

Comments

@pozdnyakov
Copy link

Some of the internal slots defined for the Sensor object are updated during the object's lifetime (e.g. lastEventFiredAt , waitingForUpdate), these slots however are never reset to their initial values after the Sensor object is stopped. Same applies to the sensor's latest reading.
@pozdnyakov pozdnyakov self-assigned this Jun 30, 2017
@pozdnyakov pozdnyakov mentioned this issue Jun 30, 2017
Merged
@alexshalamov alexshalamov added this to the Level 1 milestone Jun 30, 2017
@alexshalamov alexshalamov added this to In Progress tasks in Level 1 Jun 30, 2017
pozdnyakov pushed a commit to pozdnyakov/sensors that referenced this issue Jun 30, 2017
This patch contains massive refactoring of the abstract operations an…
ed5d3d3 
…d internal slots used in the Sensor interface specification.

The refactoring goals are:

- Stop firing events synchronously.
- Reset internal slots values after stop.
- Fix logical errors in the abstract operations.
- Recompose abstract operations so that duplication of the algorithms steps is removed.
- Drop the unused abstract operations and internal slots.

Fixes w3c#203
Fixes w3c#218
Fixes w3c#215
Fixes w3c#204
Fixes w3c#126
Fixes w3c#243
@alexshalamov alexshalamov removed this from In Progress tasks in Level 1 Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pozdnyakov pozdnyakov

Labels
None yet
Projects
None yet
Milestone
Level 1
Development

Successfully merging a pull request may close this issue.

Rewrite Abstract Operations pozdnyakov/sensors
2 participants
@pozdnyakov @alexshalamov