Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the rationale of moving security checks outside of normative requirements? #287

Closed
tobie opened this issue Sep 26, 2017 · 8 comments · Fixed by #288
Closed

What's the rationale of moving security checks outside of normative requirements? #287

tobie opened this issue Sep 26, 2017 · 8 comments · Fixed by #288

Comments

@tobie
Copy link
Member

tobie commented Sep 26, 2017

My understanding of #280 is that previously normative security checks are now examples that user agents are free to implement. What's the rationale behind this? I can't find any documented reason to make these changes. This seems like it's going to hurt end user security, and make it harder for developers to build consistent experiences across user agents. And I'm not sure I understand what benefits there is to doing so. Where can I find the arguments behind these changes?

@alexshalamov
Copy link

Any time a new sensor reading for a platform sensor is obtained and if the user agent can expose sensor readings, update latest reading is invoked with the platform sensor and the sensor reading as arguments.

Check is present in normative section 6.2 Sensor

@tobie
Copy link
Member Author

tobie commented Sep 26, 2017

Each condition of the security check used to be a RFC 2119 "MUST" requirement, they're now used as examples for something the user agent "can" do (whatever that means is up to interpretation, and it's arguably non-normative):

The user agent can define the list of conditions to check if it can expose sensor readings.

The example list of conditions is presented below:

So there's a massive difference between the current state of things and what it used to be. I'm kind of surprised this actually needs to be stated.

@lknik
Copy link
Contributor

lknik commented Sep 26, 2017

Can I ask for rationale for doing so, for example justified with some analysis?

@danbri
Copy link

danbri commented Sep 26, 2017

@alexshalamov can something be a conforming implementation of this spec if the checks shown are not routinely performed?

@tobie
Copy link
Member Author

tobie commented Sep 26, 2017

For reference, here's what the security check previously looked liked: https://cdn.rawgit.com/w3c/sensors/29065ab/index.html#security-check

It was normatively required as first step of https://cdn.rawgit.com/w3c/sensors/29065ab/index.html#update-latest-reading

@pozdnyakov
Copy link

That was an oversight, thanks for reporting! In Chromium all these checks defined in conditions are implemented. We will make them MUSTs.

@alexshalamov
Copy link

@danbri Thanks for feedback! We wanted to open possibility for UA to implement additional checks to implement required mitigation strategies. We are working on improving the definition for required checks in #288, please feel free to comment and suggest improvements.

@tobie
Copy link
Member Author

tobie commented Sep 26, 2017

I don't understand why you don't just roll these changes back instead of reworking it further. There are plenty of issues with this PR including now using normative keywords in informative sections, etc.

pozdnyakov pushed a commit to pozdnyakov/sensors that referenced this issue Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants