A Sensor instance sends 'onchange' considering its frequency hint #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes w3c#152. Each Sensor instance reads the sensor readings considering its individual frequency hint, sends 'onchange' and caches the sensor latest reading at this moment. The Sensor's attributes return values from the cached reading. Thus we achieve: 1) appearance of a new Sensor instance with a higher frequency hint does not affect the behavior of the existing Sensor instances of the same type. 2) consistency between the Sensor's 'onchange' notification and its attribute values.
tobie
requested changes
May 15, 2017
|
@tobie yeah, I am recomposing the dedicated algorithms. I'll update this PR accordingly. |
|
This is now part of #197 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152. Each Sensor instance reads the sensor readings considering its individual
frequency hint, sends 'onchange' and caches the sensor latest reading at this moment.
The Sensor's attributes return values from the cached reading.
Thus we achieve:
Preview | Diff