Fix a couple of algorithms with their use of variables #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dontcallmedom, would you mind including the generated (We disabled auto deployment in #238 since it was unreliable.) |
remove bikeshed warnings
dontcallmedom
force-pushed
the
algo-typo
branch
from
7939cb5
to
b64b58e
Compare
|
done - didn't want to do that before my other pr got merged to avoid conflicts |
|
LGTM, thanks for fixing this! |
|
Happy to get rid of those warnings, thanks @dontcallmedom for these fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove bikeshed warnings
Preview | Diff