Remove nullable member type from SensorOptions.frequency and fix warning #292
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes warning for one of the algorithms and removes ambiguous nullable dictionary member.
Reason to make
SensorOptions.frequency
non-nullable:SensorOptions
is already optional in constructorSensorOptions.frequency
is present, like in construct sensor object.null
to a possible set of frequency values, therefore, complicating algorithms.Right now, passing
{ frequency: null }
would lead to settingsensor_instance.desiredSamplingFrequency
tonull
.Preview | Diff