Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Permission API in code example #305

Merged
merged 1 commit into from
Oct 12, 2017

Conversation

alexshalamov
Copy link

@alexshalamov alexshalamov commented Oct 11, 2017

Based on TAG review, adding check using Permission API.


Preview | Diff

index.bs Outdated
let acl = new Accelerometer({frequency: 30});
let max_magnitude = 0;
acl.addEventListener('activate', () => console.log('Ready to measure.'));
acl.addEventListener('error', error => console.log('Error: ' + error.name));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Error: ${error.name}.'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@pozdnyakov pozdnyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with a nit

@alexshalamov alexshalamov force-pushed the use_permission_api branch 2 times, most recently from 758953f to 8dc1957 Compare October 12, 2017 10:54
@alexshalamov alexshalamov merged commit 899e605 into w3c:master Oct 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants