Use DOMException instead of Error in SensorErrorEvent
#307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anssiko
approved these changes
Oct 11, 2017
alexshalamov
approved these changes
Oct 11, 2017
Rationals: - `Error` is often confused with `DOMError` (pls. see w3ctag/design-reviews#110 (comment) "Should Error type rather be DOMException? (w3ctag#88)?" or w3c#142 (comment)) - In practice `DOMException` is (and probably will be) sufficient to represent the errors. - the `Error` type is not quite popular within the specs so browser vendors are reluctant to support it: https://bugs.chromium.org/p/chromium/issues/detail?id=674576 This patch is a part of the effort for fixing the [TAG review issues](w3c#303).
pozdnyakov
force-pushed
the
use_DOMException_in_events
branch
from
d3427f2
to
810d1a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationals:
Erroris often confused withDOMError(pls. see Generic Sensor API w3ctag/design-reviews#110 (comment)
"Should Error type rather be DOMException? (w3ctag#88)?" or
SensorErrorEvent IDL doesn't match Blink #142 (comment))
In practice
DOMExceptionis (and probably will be) sufficient to representthe errors.
the
Errortype is not quite popular within the specs so browser vendors arereluctant to support it:
https://bugs.chromium.org/p/chromium/issues/detail?id=674576
This patch is a part of the effort for fixing the TAG review issues.
Preview | Diff