Add content to "multiple-sensors" section #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pozdnyakov
reviewed
Oct 11, 2017
index.bs
Outdated
|
|
||
| Conversely, multiple {{Sensor|Sensors}} of the same [=sensor type=] may need to be created, when |
There was a problem hiding this comment.
s/may need to be created/may be created
index.bs
Outdated
| @@ -1503,12 +1503,17 @@ exposing [=low-level=] sensor APIs, but should also expose | |||
|
|
|||
| <h3 id="multiple-sensors">When is Enabling Multiple Sensors of the Same Type Not the Right Choice?</h3> | |||
|
|
|||
| TODO: provide guidance on when to: | |||
| It is possible to construct multiple {{Sensor}} instances of the same [=sensor type=], however, | |||
| it is not advisable to do that when these instances are constructed using equal {{SensorOptions}}, | |||
There was a problem hiding this comment.
"it is not advisable to have multiple {{Sensor}} objects that were constructed with the same construction parameters as it can unnecessarily increase CPU/power load. Instead, multiple observers should add event listeners to a single {{Sensor}} object. " wdyt?
index.bs
Outdated
|
|
||
| Conversely, multiple {{Sensor|Sensors}} of the same [=sensor type=] may need to be created, when | ||
| they are intended to be used with different settings, such as: [=requested sampling frequency=], |
anssiko
requested changes
Oct 11, 2017
index.bs
Outdated
| - allow multiple sensors of the same type to be instantiated, | ||
| - create different interfaces that inherit from {{Sensor}}, | ||
| - add constructor parameters to tweak sensors settings (e.g. setting required accuracy). | ||
| In cases when multiple observers are interested of notifications for a newly available |
index.bs
Outdated
| - create different interfaces that inherit from {{Sensor}}, | ||
| - add constructor parameters to tweak sensors settings (e.g. setting required accuracy). | ||
| In cases when multiple observers are interested of notifications for a newly available | ||
| [=sensor reading=], [=event listener=] should be added for a {{Sensor}} instead of creating |
There was a problem hiding this comment.
IIUC, perhaps:
an event listener can be added on a single Sensor instance instead of creating
We try to generally avoid using RFC 2119 terms in informative sections, thus s/should/can/.
index.bs
Outdated
|
|
||
| Conversely, multiple {{Sensor|Sensors}} of the same [=sensor type=] may need to be created, when |
alexshalamov
force-pushed
the
multiple_sensors_todo
branch
3 times, most recently
from
f67342a
to
f46c9ae
Compare
anssiko
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff