Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 'device sensor' term in the Scope section #309

Merged
merged 1 commit into from
Oct 13, 2017

Conversation

pozdnyakov
Copy link

@pozdnyakov pozdnyakov commented Oct 12, 2017

The 'device sensor' term is defined and used within the
specification. Using it in the Scope section instead of
'local sensor' makes this section consistent with the rest
of the specification contents and also more clear.

This patch is a part of the effort for fixing the
TAG review issues.


Preview | Diff

index.bs Outdated
@@ -155,8 +155,7 @@ explainer documents.
<em>This section is non-normative</em>.

The scope of this specification is currently limited
to specifying primitives
which enable expose data from local sensors.
to specifying primitives which enable expose data from [=device sensors=].

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enable user agent to expose data or enable exposure of the data, maybe something else 😄, enable expose sounds strange.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/expose/exposing/

index.bs Outdated
@@ -155,8 +155,7 @@ explainer documents.
<em>This section is non-normative</em>.

The scope of this specification is currently limited
to specifying primitives
which enable expose data from local sensors.
to specifying primitives which enable expose data from [=device sensors=].
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/expose/exposing/

Copy link

@alexshalamov alexshalamov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exposing sounds better, lgtm

The 'device sensor' term is defined and used within the
specification. Using it in the Scope section instead of
'local sensor' makes this section consistent with the rest
of the specification contents and also more clear.

This patch is a part of the effort for fixing the
[TAG review issues](w3c#303).
@pozdnyakov
Copy link
Author

@anssiko PTAL

@pozdnyakov pozdnyakov merged commit f298a40 into w3c:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants