-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Local Coordinate System" concept #340
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont like the 'which is called'. They must be resolved relative to a local coordinate system.
Or according to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Always comma before which
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
+comments from Kenneth
index.bs
Outdated
@@ -1409,6 +1431,8 @@ Gets the {{DOMException}} object passed to {{SensorErrorEventInit}}. | |||
|
|||
1. If |sensor_instance|.{{[[state]]}} is "activated", | |||
1. Let |readings| be the [=latest reading=] of |sensor_instance|'s related [=platform sensor=]. | |||
1. If the [=extension specification=] defines a [=local coordinate system=] for |sensor_instance|, | |||
1. Remap |readings| values to the [=local coordinate system=]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make reference to coordinate system transformation (reference frame). There should be plenty of books, articles. For example:
The Foundations of Celestial Mechanics George W. Collins, II
2.4 Coordinate Transformations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the link!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to define remap (point it to coordinate transformation term).
f1f43e0
to
b3c9a14
Compare
@kenchris , @alexshalamov your comments are addressed, please take a look. |
index.bs
Outdated
a <dfn export>local coordinate system</dfn> that represents | ||
a reference frame for these [=sensor readings|readings=]. | ||
A [=device sensor|sensor=] that provides such [=sensor readings|readings=] | ||
is referred as <dfn export>spatial sensor</dfn>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is referred to as
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
index.bs
Outdated
a [=local coordinate system=] for resolution. | ||
|
||
The [=local coordinate system=] normally used in a mobile device is | ||
a Cartesian coordinate system, which is defined relatively to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
relative
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done.
b3c9a14
to
10e78df
Compare
index.bs
Outdated
A [=device sensor|sensor=] that provides such [=sensor readings|readings=] | ||
is referred to as <dfn export>spatial sensor</dfn>. | ||
|
||
Depending on the number of orthogonal axes in which the measurements |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this part a bit hard to read... very long sentence with injected sentences, which then continues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wrapping it around makes it easier to read
A [=spatial sensor|sensor=] can be uniaxial, biaxial, or triaxial, depending on the number of orthogonal axes in which the measurements can be performed simultaneously by a [=spatial sensor=]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A [=spatial sensor=] can be uniaxial, biaxial,
or triaxial, depending on the number of orthogonal axes in
which it can perform simultaneous measurements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in the latest patch
index.bs
Outdated
[=spatial sensor|sensor=] can be <dfn>uniaxial</dfn>, <dfn>biaxial</dfn>, | ||
or <dfn>triaxial</dfn>. | ||
|
||
Scalar physical quantities (i.e. temperature) do not require |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why call them scalar... a x value is also a scalar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In a way, they are just values relative to a fixed scale. It gets confusing when we start talking about relative humidity, which is humidity relative to the current temperature. Maybe we could make this more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually what you want it "Non-relativistic scalars"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-relativistic scalar physical quantities such as temperature, time and mass, do not require a [=local coordinate system=] for resolution. Other scalars may have standardized frames of reference, such as relative humidity, which is relative to the current temperature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x is a vector component in a Cartesian coordinate system, i.e. the vector physical quantity is measured.
Not sure why fixed scale is required, both temperature and relative humidity won't need a spatial coordinate system, isn't it?
This is required for fixing w3c#257
10e78df
to
67f96b1
Compare
@@ -123,6 +123,17 @@ spec: webidl; type:dfn; text:identifier | |||
"title": "Sensor Use Cases", | |||
"date": "2017", | |||
"status": "Note" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks for review! |
This is required for fixing #257
Preview | Diff