Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up spec metadata #464

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Clean up spec metadata #464

merged 1 commit into from
Jul 25, 2023

Conversation

rakuco
Copy link
Member

@rakuco rakuco commented Jul 25, 2023

  • Wanming Lin (@Honry) is not working on sensors anymore, so remove the Test
    Facilitator entry.
  • Remove the Ignored Vars entry, it does not have any effect at the moment,
    and the currently recommended way of achieving the same thing is to use
    <var ignore>.
  • Remove the Boilerplate entry, there is no reason to omit the items we were
    omitting there (and some of them did not have any effect anyway):
    • Stop omitting the Conformance section, which allows us to remove the
      hand-written version we currently have as well. While at it, remove the
      extra Conformance Classes section, which defines "conformant user agent"
      without exporting it or ever referencing the term. It looks superfluous
      anyway.
    • Stop setting repository-issue-tracking to "no", which allows us to get
      rid of the Issue Tracking metadata entry.

Preview | Diff

* Wanming Lin (@Honry) is not working on sensors anymore, so remove the Test
  Facilitator entry.
* Remove the Ignored Vars entry, it does not have any effect at the moment,
  and the currently recommended way of achieving the same thing is to use
  `<var ignore>`.
* Remove the Boilerplate entry, there is no reason to omit the items we were
  omitting there (and some of them did not have any effect anyway):
  - Stop omitting the Conformance section, which allows us to remove the
    hand-written version we currently have as well. While at it, remove the
    extra Conformance Classes section, which defines "conformant user agent"
    without exporting it or ever referencing the term. It looks superfluous
    anyway.
  - Stop setting repository-issue-tracking to "no", which allows us to get
    rid of the Issue Tracking metadata entry.
@rakuco rakuco requested a review from reillyeon July 25, 2023 11:24
@rakuco rakuco merged commit d3431b7 into main Jul 25, 2023
2 checks passed
@rakuco rakuco deleted the cleanup-boilerplate branch July 25, 2023 21:03
github-actions bot added a commit that referenced this pull request Jul 25, 2023
SHA: d3431b7
Reason: push, by rakuco

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
rakuco added a commit to rakuco/orientation-sensor that referenced this pull request Aug 1, 2023
w3c/sensors#464 removed the definition of "equivalent" when the hand-written
Conformance section was replaced by the one generated by Bikeshed.

Stop referencing the term here simply by describing populateMatrix()'s steps
in a way that follows what Web IDL recommends.

Fixes w3c#75
reillyeon pushed a commit to w3c/orientation-sensor that referenced this pull request Aug 1, 2023
w3c/sensors#464 removed the definition of "equivalent" when the hand-written
Conformance section was replaced by the one generated by Bikeshed.

Stop referencing the term here simply by describing populateMatrix()'s steps
in a way that follows what Web IDL recommends.

Fixes #75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants