-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update ReSpec syntax and error fixes #70
Conversation
Marked as non substantive for IPR from ash-nazg. |
This is adding "[resource-timing]" in the set of normative references (among other additions). Not quite sure why since we already have resource-timing-2. I guess it doesn't harm anything... |
Updated in 3c03b8c
Earlier, some were linked using Question: |
We're using "current document" as a short end for "Window object's newest Document object". I agree that we should only have it once, probably keeping the definition in Resource Timing. Or better, we should stop exporting those definitions since they shouldn't really be used by other specs... |
I could not find any direct definition to the term for "Window object's newest Document object". The closest I reached was this: https://www.w3.org/TR/2015/WD-html51-20150831/browsers.html#concept-document-window, which maps to "associated document". Why is the former being used? |
I think it's historical at this point. We may be able to drop "current document" entirely and use "associated document" instead. If we're willing to make that change in server-timing, we'll need to file issues against nav- and res- timings. |
@plehegar, if you are back, friendly ping 🙏 |
@marcoscaceres , I'd like a +1 from one of the main editors before making pull requests. Hopefully, this will get noticed next week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thx for the cleanup!
@plehegar Do you want me to open issues in nav- and res- timing specs for use of |
@yoavweiss, can this be merged? These are all just small syntax changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Apologies for dropping the ball on reviewing this! |
I've made small focused commits, so they're easier to review and understand. Please squash and merge in the end.
Non-substantial for IPR.
Preview | Diff