Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ReSpec syntax and error fixes #70

Merged
merged 14 commits into from
Apr 30, 2020
Merged

chore: update ReSpec syntax and error fixes #70

merged 14 commits into from
Apr 30, 2020

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Dec 12, 2019

I've made small focused commits, so they're easier to review and understand. Please squash and merge in the end.
Non-substantial for IPR.


Preview | Diff

index.html Outdated Show resolved Hide resolved
@sidvishnoi sidvishnoi marked this pull request as ready for review December 12, 2019 20:06
@plehegar
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@plehegar
Copy link
Member

This is adding "[resource-timing]" in the set of normative references (among other additions). Not quite sure why since we already have resource-timing-2. I guess it doesn't harm anything...

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Dec 13, 2019

This is adding "[resource-timing]" in the set of normative references

Updated in 3c03b8c

(among other additions)

Earlier, some were linked using href (instead of data-cite) - so those references were missing. Also, some have moved from informative to normative.

Question: current document is linked to both navigation-timing-2 as well as resource-timing-2. Only one those specs (or some other spec) should be defining it (and we should be linking to that only) - so I think that's a bug.

index.html Outdated Show resolved Hide resolved
@plehegar
Copy link
Member

We're using "current document" as a short end for "Window object's newest Document object". I agree that we should only have it once, probably keeping the definition in Resource Timing. Or better, we should stop exporting those definitions since they shouldn't really be used by other specs...

@sidvishnoi
Copy link
Member Author

I could not find any direct definition to the term for "Window object's newest Document object". The closest I reached was this: https://www.w3.org/TR/2015/WD-html51-20150831/browsers.html#concept-document-window, which maps to "associated document". Why is the former being used?

@plehegar
Copy link
Member

I think it's historical at this point. We may be able to drop "current document" entirely and use "associated document" instead. If we're willing to make that change in server-timing, we'll need to file issues against nav- and res- timings.

@marcoscaceres
Copy link
Member

@plehegar, if you are back, friendly ping 🙏

@plehegar
Copy link
Member

plehegar commented Jan 2, 2020

@marcoscaceres , I'd like a +1 from one of the main editors before making pull requests. Hopefully, this will get noticed next week.

Copy link
Contributor

@cvazac cvazac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thx for the cleanup!

@sidvishnoi
Copy link
Member Author

@plehegar Do you want me to open issues in nav- and res- timing specs for use of "associated document"? Or this can be merged before we do that?

@marcoscaceres
Copy link
Member

@yoavweiss, can this be merged? These are all just small syntax changes.

Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoavweiss yoavweiss merged commit 36c2e8b into w3c:gh-pages Apr 30, 2020
@yoavweiss
Copy link
Contributor

Apologies for dropping the ball on reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants