Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add missing period, correct spelling #526

Closed
wants to merge 1 commit into from
Closed

docs: add missing period, correct spelling #526

wants to merge 1 commit into from

Conversation

j9t
Copy link

@j9t j9t commented May 24, 2021

…and (automatically) remove trailing spaces

Signed-off-by: Jens Oliver Meiert jens@meiert.com

Signed-off-by: Jens Oliver Meiert <jens@meiert.com>
Copy link
Member

@michael-n-cooper michael-n-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be mainly whitespace changes, which make it difficult to see what other changes the PR makes, and therefore to review. Generally whitespace changes should not be made as part of a PR unless it's a) critical or b) the point of the PR, as it gets hard to track history with whitespace commits in the mix.

@j9t
Copy link
Author

j9t commented May 27, 2021

That was tooling-related. I believe the changes are fairly quick to review—if you don’t want the punctuation and spelling fixes, discard the PR.

<li>Support a measurement and conformance structure that includes guidance for a broad range of disabilities. This includes more attention to the needs of low vision and cognitive accessibility, whose needs may not fit the true/false statement success criteria of WCAG 2.x.
<li>Consider the needs of more organizations
<li>Treat the needs of all disabilities equitably.
<li>Support a measurement and conformance structure that includes guidance for a broad range of disabilities. This includes more attention to the needs of low vision and cognitive accessibility, whose needs may not fit the true/false statement success criteria of WCAG 2.x.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period added

Copy link
Contributor

@jspellman jspellman Jun 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes a new(ish?) feature in settings on the Files tab to hide white space changes.
But it has IPR issues, so I'll create a new PR as previously discussed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting. Replaced by #533

@michael-n-cooper michael-n-cooper self-assigned this Jun 2, 2021
jspellman added a commit that referenced this pull request Jun 6, 2021
@jspellman jspellman closed this Jun 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants