Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assigned to every li-s and notes #31

Merged
merged 4 commits into from
Jun 1, 2020
Merged

assigned to every li-s and notes #31

merged 4 commits into from
Jun 1, 2020

Conversation

himorin
Copy link
Contributor

@himorin himorin commented May 29, 2020 •
edited by pr-preview bot
Loading

closes #22

Preview | Diff

@himorin himorin requested a review from kidayasuo May 29, 2020 07:50
kidayasuo
kidayasuo approved these changes May 29, 2020
View reviewed changes
Copy link
Contributor

@kidayasuo kidayasuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving. Should Fuqiao be reviewing the change too as he requested the change?

@himorin himorin requested review from kidayasuo and xfq May 29, 2020 16:04
@xfq
Copy link
Member

xfq commented May 30, 2020

I might be missing something, but it looks like the format is n/nl + yyyy + mm + dd + (three-digit) ID.

If so, should nl0200529001 be nl20200529001? (Same for others.)

@himorin
Copy link
Contributor Author

himorin commented Jun 1, 2020

YES!!
Thank you for catching that.. I'll replace ones for li from "nl02005xxx" to "l202005xxx". (it seems some regexp replace command was wrongly processed during editing..)

@r12a r12a merged commit 634e56a into w3c:gh-pages Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kidayasuo kidayasuo Awaiting requested review from kidayasuo

@xfq xfq Awaiting requested review from xfq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assign ID to each note part and list item
4 participants
@himorin @xfq @kidayasuo @r12a