Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit refs and refs unification #22

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Explicit refs and refs unification #22

merged 2 commits into from
Nov 2, 2023

Conversation

domel
Copy link
Contributor

@domel domel commented Sep 21, 2023

"rfc*" -> "RFC*"


Preview | Diff

@domel domel added the spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text) label Sep 21, 2023
@rubensworks
Copy link
Member

With this change, many references show up twice. Are we sure we want this?
Perhaps the inline data-cite link is enough?

Screenshot 2023-09-21 at 18 04 15

@domel
Copy link
Contributor Author

domel commented Sep 21, 2023

@rubensworks the first RFC* is a link to a particular (sub)section, and the second RFC* is a general reference.

spec/index.html Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
<dd>An HTTP client (as defined by
<a data-cite="rfc9110#section-3.3">Section 3.3. Connections, Clients, and
Servers</a> of [[[RFC9110]]] [[RFC9110]]) that sends HTTP requests for
SPARQL Protocol operations. (Also known as: <em>client</em>.)</dd>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to duplicate the next paragraph

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I had made a suggestion, which was meant to lead to a decision between the paragraph above and the paragraph below, which are better compared in the preview. I prefer the top/first paragraph (which includes the title of the cited section, as well as the title of the RFC, along with the RFC####). If this is accepted/adopted, then I think the other citations should be tweaked in similar fashion.

<dd>An HTTP client (as defined by
<a data-cite="rfc9110#section-3.3">Section 3.3. Connections, Clients, and
Servers</a> of [[[RFC9110]]] [[RFC9110]]) that sends HTTP requests for
SPARQL Protocol operations. (Also known as: <em>client</em>.)</dd>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I had made a suggestion, which was meant to lead to a decision between the paragraph above and the paragraph below, which are better compared in the preview. I prefer the top/first paragraph (which includes the title of the cited section, as well as the title of the RFC, along with the RFC####). If this is accepted/adopted, then I think the other citations should be tweaked in similar fashion.

@domel domel merged commit 62ba29f into main Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:editorial Minor issue or proposed change in the specification (markup, typo, informative text)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants