Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(action.yml): use .nvmrc, package.json in action repo #165

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

sidvishnoi
Copy link
Member

Closes #164

@sidvishnoi
Copy link
Member Author

sidvishnoi commented Sep 12, 2023

actions/setup-node presently doesn't support absolute node-version-file. Filed actions/setup-node#852.
Will use node-version until that is fixed. Decided to pass relative URLs instead.

@sidvishnoi sidvishnoi changed the title fix(action.yml): search .nvmrc in action repo, not in user repo fix(action.yml): search .nvmrc, package.json in action repo, not user repo Sep 12, 2023
@sidvishnoi sidvishnoi changed the title fix(action.yml): search .nvmrc, package.json in action repo, not user repo fix(action.yml): use .nvmrc, package.json in action repo, not user repo Sep 12, 2023
@sidvishnoi sidvishnoi changed the title fix(action.yml): use .nvmrc, package.json in action repo, not user repo fix(action.yml): use .nvmrc, package.json in action repo Sep 12, 2023
@sidvishnoi sidvishnoi marked this pull request as ready for review September 12, 2023 11:22
@sidvishnoi sidvishnoi merged commit 958b6d5 into main Sep 12, 2023
1 check passed
@sidvishnoi sidvishnoi deleted the fix-nvmrc branch September 12, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The specified node version file at .nvmrc does not exist
1 participant