Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't require ARTIFACT_NAME with multiple specs #181

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

sidvishnoi
Copy link
Member

@sidvishnoi sidvishnoi commented Apr 17, 2024

Automatically generate artifact name based on source. Respect ARTIFACT_NAME set in inputs, as added in #180.

So that #173 will no longer be a breaking as mentioned v2.11.2.

The artifact name may change from spec-prod-result even with single spec, though some effort was made to keep it stable (i.e. if source is index.html or index.bs). The automatic name will still start with spec-prod-result.


Preview | Diff

@sidvishnoi
Copy link
Member Author

@oliverdunk FYI. No longer require to update workflows to define ARTIFACT_NAME.

@sidvishnoi sidvishnoi merged commit e690b1b into main Apr 17, 2024
2 checks passed
@sidvishnoi sidvishnoi deleted the automatic-artifact-name branch April 17, 2024 13:31
github-actions bot added a commit that referenced this pull request Apr 17, 2024
SHA: e690b1b
Reason: push, by sidvishnoi

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@oliverdunk
Copy link
Member

Thanks @sidvishnoi! Much more polished :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants