Allow https URLs for in PP URL checks. #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sideshowbarker
added a commit
to w3c/webdriver
that referenced
this pull request
Aug 3, 2015
The "specberus" tool that runs automated checks as part of the WG automatic-publishing-to-TR-space system is currently hardcoded to look for an "http" scheme in the wgPatentURI URL. w3c/specberus#222 is a PR that I've opened to fix that, but in the mean time we'll need to use the insecure URL instead, then switch this back once that specberus PR is merged.
| text === "Essential Claim(s)") { | ||
| foundEssentials = true; | ||
| return; | ||
| } | ||
| if (href === "http://www.w3.org/Consortium/Patent-Policy-20040205/#sec-Disclosure" && | ||
| if ((href === "http://www.w3.org/Consortium/Patent-Policy-20040205/#sec-Disclosure" || | ||
| href === "http://www.w3.org/Consortium/Patent-Policy-20040205/#sec-Disclosure") && |
deniak
added a commit
that referenced
this pull request
Aug 3, 2015
Allow https URLs for in PP URL checks.
| text === "5 February 2004 W3C Patent Policy") { | ||
| foundFeb5 = true; | ||
| return; | ||
| } | ||
| if (/^http:\/\/www\.w3\.org\/2004\/01\/pp-impl\/\d+\/status(#.*)?$/.test(href) && | ||
| if (/^http[s]*:\/\/www\.w3\.org\/2004\/01\/pp-impl\/\d+\/status(#.*)?$/.test(href) && |
There was a problem hiding this comment.
/^https?:\/\/... is more accurate, and simpler.
(Nevermind, sorry I didn't see this earlier… :¬)
sideshowbarker
added a commit
that referenced
this pull request
Aug 16, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.