Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The expressions and illustrations in the vector effects chapter of SVG 2 CR are broken. #297

Closed
satakagi opened this issue Nov 24, 2016 · 5 comments

Comments

@satakagi
Copy link
Contributor

http://www.w3.org/TR/SVG2/coords.html#VectorEffects

However, they of working draft look normal.
https://svgwg.org/svg2-draft/coords.html#VectorEffects

The situation of the single page version is also the same.

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Nov 24, 2016

Part of the problem is MathJax is not running. On Chrome, I'm getting "Uncaught ReferenceError: local is not defined at https://www.w3.org/TR/SVG2/style/load-mathjax.js:3:10." Firefox gives an equivalent error. If you look at the source code, the MathML is still there. But it's not displaying, not even in Firefox (which should have native MathML support).

The other problem is that the folder of supporting images (images/painting/vectorEffects/) doesn't seem to have been copied over to the TR/SVG2/ file tree.

@nikosandronikos I think you were tweaking some of the scripts with respect to MathJax last month. Was that with respect to the missing local variable? Do you or @shepazu know how to fix the missing image files?

@nikosandronikos
Copy link
Member

Regarding the images, I can confirm that they were in the archive to be uploaded. So it's just an oversight that they are missing.
I don't have access, but @shepazu can hopefully add them from http://andronikos.id.au/svg2-august-cr/publish/images/painting/vectorEffects/
Since they should have been initially uploaded, I can't see any problem in just adding them now.

For the exception in load-mathjax.js, I hadn't done any work on that. But I can see the problem. local is defined in link-fixup.js. But that script is only included in Editors Drafts. So the fix is to check whether local is actually defined before trying to reference it. I've uploaded and verified a fix here. Perhaps @shepazu could copy that version over the one published with the SVG 2 CR?

@nikosandronikos
Copy link
Member

Note today is a holiday in the US, so I'll set myself a reminder to ping @shepazu tomorrow or Monday.

@boggydigital boggydigital added this to the SVG 2.0 Recommendation milestone Jun 11, 2018
@boggydigital
Copy link
Contributor

Not blocking updated 2.0 CR publication - assigning 2.0 Recommendation milestone to clean this up before 2.0 REC

@svgeesus
Copy link
Contributor

svgeesus commented Aug 5, 2018

Both the math and the images are correct in the latest CR so closing this as fixed.

I didn't have to do anything special except to remember the image directory is three levels deep when CVS adding the fils.

@svgeesus svgeesus closed this as completed Aug 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants