Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove color-rendering CSS property #647

Closed
longsonr opened this issue Feb 22, 2019 · 7 comments
Closed

Remove color-rendering CSS property #647

longsonr opened this issue Feb 22, 2019 · 7 comments

Comments

@longsonr
Copy link

https://www.w3.org/TR/SVG2/painting.html#ColorRendering

It has no normative requirements.

Only Chrome implements passes all the WPT tests for it of it and I don't know what they do with it beyond parsing it.

@dholbert
Copy link
Member

@progers : hi! biesi told me you might be a person who could weigh in here on the Chrome side -- could you tell us if Chrome actually does anything with this property? (And would you be OK removing it?)

@dholbert
Copy link
Member

(biesi says @fsoder might also be able to weigh in on this)

@fsoder
Copy link

fsoder commented Feb 28, 2019

Blink does not actually do anything with the color-rendering property. It would hopefully be OK to remove it.

@AmeliaBR
Copy link
Contributor

AmeliaBR commented Mar 1, 2019

@dirkschulze @Tavmjong is this property used in graphical SVG editors to your knowledge?

The color-rendering property is about hinting to the user agent about performance trade-offs, though, so I can't see it being that relevant in print media. So if it has no impact in browsers, that would be a good argument for removing it.

CSS Color Level 4 currently includes a color-adjust property that has a lot of similarities to color-rendering, but is defined in terms of modern device behavior. I'm not sure if there is any value in keeping color-rendering around as a legacy synonym. It would depend on whether it's actually being used in content.

@dirkschulze
Copy link
Contributor

As far as I can tell, Adobe products neither import nor generate color-rendering.

@css-meeting-bot
Copy link
Member

The SVG Working Group just discussed remove color-rendering, and agreed to the following:

  • RESOLUTION: Drop color-rendering and update parsing tests. Revisit on objections.
The full IRC log of that discussion <krit> topic: remove color-rendering
<krit> GitHub: https://github.com//issues/647
<krit> AmeliaBR: one of the SVG 1.1 hint properties. Authors could tell engine to optimise speed or quality.
<krit> AmeliaBR: AFAIK no UA does actively support it.
<krit> AmeliaBR: Blink parses it at least
<krit> AmeliaBR: Firefox doesn't so.
<krit> myles: what was the original intention?
<krit> myles: what could an implementation do?
<krit> AmeliaBR: color interpolation, compositing
<krit> AmeliaBR: linearRGB might be faster than sRGB... but that might no longer be true.
<krit> myles: I would be comfortable with removing this.
<krit> krit: Don;t know Adobe product that makes use of it on either import or generating SVG documents.
<krit> AmeliaBR: There is no legacy issue. It is not breaking anything.
<krit> krit: we could get a resolution and see if we get objections.
<krit> AmeliaBR: Safari just accepts the camel case version.
<krit> AmeliaBR: ... for keywards
<krit> myles: checking if webkit does anything with it...
<krit> AmeliaBR: minimal action would be to mark it as at-risk
<krit> myles: don't see any use in WebKit
<krit> myles: 's implementation itself beside computed style
<krit> RESOLUTION: Drop color-rendering and update parsing tests. Revisit on objections.
<krit> krit: while we are at it, what about color-interpolation.
<krit> AmeliaBR: need to check comments
<krit> AmeliaBR: IIRC only Batik supported Color-interpolation.

@svgeesus
Copy link
Contributor

svgeesus commented May 7, 2019

OK, I will make a PR removing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants