Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #345 Add [Exposed] to SVG interfaces #387

Merged
merged 1 commit into from Mar 22, 2018

Conversation

dstorey
Copy link
Member

@dstorey dstorey commented Feb 14, 2018

WebIDL now requires interfaces to explicitly define that they are exposed to Window.

@dstorey
Copy link
Member Author

dstorey commented Mar 9, 2018

@tobie does this look correct to you? It's the change I've just added to Edge.

@tobie
Copy link
Member

tobie commented Mar 9, 2018

LGTM. Thanks for doing this!

@boggydigital boggydigital self-requested a review March 22, 2018 22:22
@boggydigital boggydigital merged commit 366ba70 into w3c:master Mar 22, 2018
foolip added a commit to foolip/svgwg that referenced this pull request Apr 14, 2021
These were missed in w3c#387 and should be
the last cases of missing [Exposed] in SVG.
foolip added a commit to foolip/svgwg that referenced this pull request Apr 14, 2021
These were missed in w3c#387 and should be
the last cases of missing [Exposed] in SVG.
dontcallmedom pushed a commit that referenced this pull request Apr 21, 2021
These were missed in #387 and should be
the last cases of missing [Exposed] in SVG.
blindmanyo44 added a commit to blindmanyo44/svgwg that referenced this pull request Dec 19, 2021
commit f9e6b78
Merge: cf16686 1cd12e8
Author: Dominique Hazael-Massieux <dom@w3.org>
Date:   Thu Apr 22 22:02:13 2021 +0200

    Merge branch 'main'

commit cf16686
Merge: 2a5117e f19f38d
Author: Dominique Hazael-Massieux <dom@w3.org>
Date:   Wed Apr 21 09:16:26 2021 +0200

    Merge branch 'main'

commit 2a5117e
Author: Dominique Hazael-Massieux <dom@w3.org>
Date:   Wed Apr 21 09:00:50 2021 +0200

    Add definition for CSSPseudoElement interface

    Follow up to 840

commit 9143992
Author: Philip Jägenstedt <philip@foolip.org>
Date:   Wed Apr 14 09:42:41 2021 +0200

    Add remaining [Exposed=Window] where still missing

    These were missed in w3c#387 and should be
    the last cases of missing [Exposed] in SVG.

commit 4520451
Author: Philip Jägenstedt <philip@foolip.org>
Date:   Thu Apr 1 12:43:17 2021 +0200

    Replace void with undefined in Web IDL

    See whatwg/webidl#906.

commit 0f465d2
Author: Philip Jägenstedt <philip@foolip.org>
Date:   Wed Feb 17 14:16:08 2021 +0100

    [svg-paths] Add default value {} to getPathData argument

    This is required by Web IDL.

commit 06acb1c
Author: Nick Schonning <nschonni@gmail.com>
Date:   Mon Feb 8 14:05:40 2021 -0500

    [color] Double link wraps in Bikeshed

commit b65265f
Merge: 5b7a1d3 fb6c169
Author: Tab Atkins Jr <jackalmage@gmail.com>
Date:   Tue Apr 20 10:31:43 2021 -0700

    Merge pull request w3c#840 from foolip/patch-1

    Avoid the use of Animatable as a Web IDL type

commit fb6c169
Author: Philip Jägenstedt <philip@foolip.org>
Date:   Tue Apr 20 11:48:54 2021 +0200

    Avoid the use of Animatable as a Web IDL type

    As an interface mixin, Animatable can't be used as a type per Web IDL:
    https://heycam.github.io/webidl/#idl-types

    Expand it to (Element or CSSPseudoElement), the two interfaces that include Animatable.

commit 5b7a1d3
Merge: 693d8cc 7936ab4
Author: Tab Atkins Jr <jackalmage@gmail.com>
Date:   Fri Feb 26 08:51:28 2021 -0800

    Merge pull request w3c#825 from foolip/patch-2

    Use constructor operation for ShadowAnimation

commit 7936ab4
Author: Philip Jägenstedt <philip@foolip.org>
Date:   Tue Feb 16 14:41:57 2021 +0100

    Use constructor operation for ShadowAnimation

    The Constructor extended attribute has been removed from Web IDL.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants