Clarify that bounding box of foreignObject is hit-teasting target and… #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… content may be too. #427
dirkschulze
requested review from
AmeliaBR,
Tavmjong,
svgeesus and
ewilligers
svgeesus
approved these changes
Dec 10, 2018
master/changes.html
Outdated
| <div class='changed-since-cr1 cr2'> | ||
| <ul> | ||
| <li>Removed the use element from list of elements that the <a>'visibility'</a> property directly affects. | ||
| <li class='changed-since-cr1 cr3'>Clarify that <a>'foreignObject'</a> is and its content may be hit-testing target.</li> |
There was a problem hiding this comment.
Suggested change
| <li class='changed-since-cr1 cr3'>Clarify that <a>'foreignObject'</a> is and its content may be hit-testing target.</li> | |
| <li class='changed-since-cr1 cr3'>Clarify that <a>'foreignObject'</a> is, and its content may be, hit-testing target.</li> |
There was a problem hiding this comment.
the subordinate clause is more readable with the commas.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… content may be too. #427