Enum-like DOM properties throw TypeErrors on setting to unknown values #641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As resolved in w3c#547 (comment) > RESOLUTION: Setting a enum-like DOM property to a value > that doesn't represent a valid attribute value > should throw a TypeError This affects the setter algorithm for SVGAnimatedEnumeration and for SVGPreserveAspectRatio. Clarifying changes made to: - the note regarding reserializing an SVGAnimatedEnumeration, - the general statement about silently ignoring invalid values. Closes w3c#547.
birtles
approved these changes
Jan 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As resolved in #547 (comment)
This affects the setter algorithm for
SVGAnimatedEnumeration
and for SVGPreserveAspectRatio.
Clarifying changes made to:
silently ignoring invalid values.
Closes #547.