Remove onfocusin and onfocusout event attributes. #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@heycam The resolution seems to imply that we want to remove them when we can reference them from HMTL instead. IIRC this patch just removes the focus attributes. Did you check if they were added to HTML? |
|
@dirkschulze I didn't check, but that haven't been yet. I read the resolution as asking for the attributes to be removed, but they will come back automatically at some point when they're defined in HTML. Do you suggest blocking on HTML before merging this? |
|
@heycam Reading the IRC log it seems we resolved to remove even if they aren't in HMTL yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715