Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand mouse/click interactions #65

Merged
merged 1 commit into from Apr 25, 2016
Merged

Expand mouse/click interactions #65

merged 1 commit into from Apr 25, 2016

Conversation

patrickhlauke
Copy link
Member

  • introduce the concept of "compatibility" mouse events (to explain why UAs may choose to fire both touch and mouse/click)
  • remove stray "the"
  • expand note about when UAs typically don't fire mouse events+click - not just mutli-touch, but also any gestures that aren't a tap
  • optimistically replace "click" with "activation/tap gesture", hoping lawers won't swoop down on it

@patrickhlauke
Copy link
Member Author

patrickhlauke commented Apr 22, 2016

the third bullet addresses #63

@@ -895,13 +895,13 @@ <h3 id="event-touchcancel">The <dfn class="event"><code>touchcancel</code></dfn>
</p>

<p class="note">
User agents will typically dispatch mouse and click events when there is only a single
<a>active touch point</a>. Multi-touch interactions – involving two or more
User agents will typically dispatch mouse and click events only for an activation/tap gesture, and only when there is a single
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most UAs send mouse events / contextmenu for a long press gesture too, right?

@RByers
Copy link
Contributor

RByers commented Apr 25, 2016

Looks good generally though we probably need to relax this slightly to handle long press or other contextmenu scenarios. Obviously we don't want to try to define gesture behavior exactly, just capture the most common developer expectations. For example, note that Chrome on desktop also implements a two-finger tap gesture as a contextmenu accelerator (that doesn't require waiting for the long press timer) but I don't think it's worth mentioning that explicitly.

@patrickhlauke
Copy link
Member Author

would just saying "tap gesture" rather than "activation/tap gesture" be sufficiently vague to cover contextmenu as well (and lax enough for the two-finger tap accelerator gesture due to the "typically" at the start)?

@RByers
Copy link
Contributor

RByers commented Apr 25, 2016

Not in chromium's gesture terminology, no ("tap" and "long press" are entirely different gestures). You could say "single finger stationary gestures" to include them both. Or even just call them out explicitly, eg, "single finger activation gestures (like tap and long press)". I agree "typically" is enough to let us ignore the niche cases like "two finger tap".

@patrickhlauke
Copy link
Member Author

single finger activation gestures (like tap and long press)

liking that...will make a change and force-push result

@patrickhlauke
Copy link
Member Author

done

@@ -895,13 +895,13 @@ <h3 id="event-touchcancel">The <dfn class="event"><code>touchcancel</code></dfn>
</p>

<p class="note">
User agents will typically dispatch mouse and click events when there is only a single
<a>active touch point</a>. Multi-touch interactions – involving two or more
User agents will typically dispatch mouse and click events only for single finger activation gestures (like tap and long press), and only when there is a single
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the "and only when..." is now redundant with "single finger", right? Could just remove the 2nd part entirely?
Also should "single finger" be hyphenated?

@patrickhlauke
Copy link
Member Author

@RByers right on both comments. fixed.

@RByers
Copy link
Contributor

RByers commented Apr 25, 2016

LGTM, thanks!

@RByers RByers merged commit 85d68da into w3c:gh-pages Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants