Dark mode #202
Merged
Dark mode #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t bgs that weren't designed with the assumption of beign displayed on a dark bg.
|
Will need to check how it plays with ReSpec generated specs. I'm a little break at the moment - but will take a look as soon as I can. |
fantasai
reviewed
Sep 8, 2020
| --a-active-underline: var(--a-active-text); | ||
|
|
||
| --blockquote-border: silver; | ||
| --blockquote-bg: #181818; |
There was a problem hiding this comment.
Please check this background color against http://fantasai.inkedblade.net/style/design/w3c-restyle/2020/readme#amendment I don't think opaque gray works well when the blockquote is within a differently-colored box for the same reason that opaque white didn't work well in the light colors when you refactored them.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dark-mode variants of the colors. I tested them all personally, so afaict they should look good.
Note that Bikeshedded specs have some colors applied on their own, so if you naively spam this in you'll still have some bad color combinations; this should be merged with/after Bikeshed lands its dark-mode styling as well.
This also replaces/closes #184.