Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the page responsive #21

Closed
tanyeah opened this issue Dec 14, 2017 · 2 comments
Closed

Make the page responsive #21

tanyeah opened this issue Dec 14, 2017 · 2 comments
Assignees
Labels
enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018)

Comments

@tanyeah
Copy link
Contributor

tanyeah commented Dec 14, 2017

The page needs to be responsive (as confirmed by @deniak).

I don't see a need for an elaborate design mock-up, here. Maybe just:

  • Transition the main content from a two-column to a single column layout
  • Make the sidebar horizontal, move to the top of the page
  • Filters below the horizontal sidebar, either made sticky, or with a 'scroll to top' arrow (pointing upwards) in the bottom right of the screen that makes the jump to the filter section easy for users

@tripu, what do you think?

@tanyeah tanyeah added enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018) labels Dec 14, 2017
@tripu
Copy link
Member

tripu commented Feb 5, 2018

@tanyeah, in order to distribute items better according to available space, I think it'd be better to do one of these two things:

  • We make ul#container be display: flex, and set limits to the min and max sizes of its li children
  • Or, in ul#container we set property column-count to a value that we determine dynamically, using media queries (eg, from 1 for small screens to 4 for very wide ones); and make its li children be display: block.

Either case, the number of columns would vary automatically depending on the width available. I think the list of specs would look better that way.

WDYT?

/cc @deniak

@deniak
Copy link
Member

deniak commented Feb 6, 2018

👍 to have different number of columns depending on the screens.
Flexbox is widely supported so I'd favor that method.

@tanyeah tanyeah mentioned this issue Mar 8, 2018
tanyeah added a commit that referenced this issue Mar 9, 2018
Fixes Issue #21 : Make the page responsive.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Something could be improved (as opposed to “doesn't work as it should”) mock-up-1 About our first iteration (released ~ 20 Mar 2018)
Projects
None yet
Development

No branches or pull requests

3 participants