Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide vendor/open source product name register for tracestate #58

Closed
wu-sheng opened this issue Feb 5, 2018 · 13 comments
Closed

Provide vendor/open source product name register for tracestate #58

wu-sheng opened this issue Feb 5, 2018 · 13 comments
Assignees
Labels
Milestone

Comments

@wu-sheng
Copy link
Contributor

wu-sheng commented Feb 5, 2018

Based on our workshop, see #57 . Every product need a name in header, which should be unique in global, in order to make sure the context is safe for each vendor or product.

I proposal to maintain a vendors or products name register list, to make sure no conflict about name.

@AloisReitbauer
Copy link
Contributor

As a first step we can simply start a document that acts as an informal registry. Good enough?

@wu-sheng
Copy link
Contributor Author

Yes, agree.

@AloisReitbauer
Copy link
Contributor

@wu-sheng I pushed back on the PR as I think it goes to far. Can we start with a list of reserved names e.g. nr for new relic, dt for dynatrace etc. I don't want specify the format of the tags, because I also don't think this is necessary.

I think having two tracers of the same time is different problems, so I would create a separate issue for this.

@wu-sheng
Copy link
Contributor Author

wu-sheng commented Apr 2, 2018

I am OK with that, if others agree. I start this because SkyWalking is actually facing this, and provided advanced namespace feature, which will be released in 5.0.0 beta.

@SergeyKanzhelev SergeyKanzhelev modified the milestones: FPWD, CR Apr 17, 2018
@SergeyKanzhelev SergeyKanzhelev changed the title Provide vendor/open source product name register for "trace-state" Provide vendor/open source product name register for tracestate Aug 7, 2018
@SergeyKanzhelev SergeyKanzhelev modified the milestones: 4. CR, 5. PR Aug 7, 2018
@tylerbenson
Copy link

Any update on this? I think there was some good progress on #88 which was later discarded. As people start implementing this, I think it's important to have.

@AloisReitbauer @SergeyKanzhelev?

@discostu105
Copy link
Member

It would be good to have this. We're already actively using tracestate with our own key ("dt" for now). How would we wanna track this registry? Separate github repo? Document in this repo?

@AloisReitbauer
Copy link
Contributor

As we now have the registry, I assume we can close this?

@yurishkuro
Copy link
Member

Sorry, where do we have the registry?

@danielkhan danielkhan self-assigned this Aug 27, 2019
@AloisReitbauer
Copy link
Contributor

We have the registry available now.

@yurishkuro
Copy link
Member

once again, where is the registry?

@danielkhan
Copy link
Contributor

@yurishkuro it's here https://github.com/w3c/trace-state-ids-registry but we clearly have to add that to make this more visible. Reopening to track this.

@danielkhan danielkhan reopened this Sep 25, 2019
@yurishkuro
Copy link
Member

Even there it's just a placeholder, nobody actually registered their IDs?

@danielkhan danielkhan modified the milestones: 5. PR, 7. level-2 Mar 25, 2020
@danielkhan
Copy link
Contributor

The registry is in effect and will be filled now by vendors.
Anyone interested in registering their ID please join

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants