-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracestate name registery #88
Conversation
@@ -0,0 +1,7 @@ | |||
# Trace State Registry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think something like this is two-fold: one is format and another is well-known-public-provider.
For example: aws might be referring to their format? It could also be referring to the public cloud itself.
It is worth considering. Also, I think the first format on the list should be equivalent to the traceparent
maybe the label tc
for native trace-context format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reason I use the amazon example is that early days "ec2" was both an api and also a public service. People started cloning the api. In the jclouds project, we had to come up with a way to describe the api separate from the provider of it. Incidentally we used the same registry for both. Ex "aws-ec2" was a provider of "ec2", but both labels were in the same registry for ease of use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriancole I just want to setup a registry for format, which relates to public service provider, vendor or project. And each on of them can choose a name and keep it public to else.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adriancole such as, if AWS support this sepc, their X-RAY need a tracestate name in value field. They should choose their own.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so @wu-sheng you think to put entire header as described in the link as a trace state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeyKanzhelev I think that could be optional, if this format is open. This maybe help people to diagnose interop issues.
right. my comments were more about guidance on why this exists and what
would be a reason it should be updated. I think we'll need some "intro
section" in other words.
|
|
||
| Trace State Name | Verdor / Project Name | website | | ||
| - | :-: | - | | ||
| sw | Apache SkyWalking (Incubating) | http://skywalking.io/ | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fyi if we had such a registry, the table should point to the actual format.
basically as a developer or even a user, if I go to a table for a trace state entry, it should bring me exactly to the state definition... remember this? https://drive.google.com/drive/u/0/folders/0B0tSnQT3uGdAWU00QW1HQUFGeG8 (not sure you can see it)
Maybe you are better than me to write this intro section. What do you think? I am afraid my English is not so native enough. And format column added. |
@wu-sheng I'll happily add the intro section, by adding a commit to your branch. I'm going to wait until a couple others give feedback first. |
Do we still have an open question whether the labels should be just (vendor) or (vendor-site)? |
@yurishkuro Do you mean the |
I mean something like |
I think the label thing is for two isolated/independent but same tracing system monitoring the whole distributed tracing system. And the e.g. You can use New Relic/Jaeger for monitoring a distributed system, OR, you can use two separated Jaegers to trace a distributed system. So, in my perspective, they are different usage.
And another example, I think should put this in this way, because in Huawei cloud, we provide SkyWalking cloud service, which should be isolated with end user's own monitoring system(assume they use SkyWalking, just for example). |
There are three reasons to have a registry. First is to claim a key. Second - document vendor specific
The whole point of the standard is to make more systems act the same way. This is one of the reason @AloisReitbauer pushing to have a unified export format discussed as well. So you can build an APM product by importing spans from different systems. Yes, vendors might have specifics and extra features. Ideally though, basic behavior should be preserved when possible. So @yurishkuro I like the idea of labels. Specific of Application Insights is that it's optimized for high-tenancy model. Every application can be (and many times is) a separate tenant. ACL is a backend feature that decides which subset of applications one have access to. So |
@SergeyKanzhelev I think The examples just show why I think |
Can someone please fix the English language here, so we can merge the PR |
Yes, please some native English guys help me on this.😃😃 |
I like shipping things.. I think there are several points of concern mentioned based on usage patterns not actually defined in the text. The actual changes here only discuss a registry and claiming a label. There's no mention as to why apart from avoiding conflict. We MUST have an example, to help pin this down. If you want me (or someone else, but I'm fine) to clean up the english, I would say something like..
Personally, I think we MUST define format labels regardless of if we make a name claiming thing for public services. In other words, I might narrowly define this as format as that could lead to a quicker merge and we can still have a separate change to talk about name claiming for vendors. When I get some guidance on this, happy to weave it in, or someone else can. |
I think this should make things clear. At least for me. |
Cleaned up wording |
@AloisReitbauer You can check this pr now. :) @SergeyKanzhelev @yurishkuro @bogdandrutu are you OK with this? |
As we discussed yesterday on the call, the suggestion is to close this PR and move the wording to an issue, for further discussion, because it seems premature to start maintaining the registry before the final agreement is reached about the semantics of the keys in the trace-state (i.e. is it a vendor name, or format name, or something + site name, etc.) |
@wu-sheng During the call we decided to close the PR and defer further decision for the next F2F meeting. Good with that? |
Moving the discussion back to the issue first. |
Related to #58 ,
Provide vendor/open source product name register for "trace-state"