Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft of binary format: moved to other repository #215

Closed
wants to merge 4 commits into from

Conversation

SergeyKanzhelev
Copy link
Member

@SergeyKanzhelev SergeyKanzhelev commented Dec 5, 2018

PR was moved

This PR was moved here: w3c/trace-context-binary#2

Copy link

@watson watson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this getting started! 💯

spec/Binary/20-BINARY_FORMAT.md Outdated Show resolved Hide resolved
spec/Binary/20-BINARY_FORMAT.md Outdated Show resolved Hide resolved
spec/Binary/20-BINARY_FORMAT.md Outdated Show resolved Hide resolved
spec/Binary/20-BINARY_FORMAT.md Show resolved Hide resolved
@yurishkuro
Copy link
Member

Why not define the binary format using protobuf IDL instead of inventing some custom encoding?

@SergeyKanzhelev
Copy link
Member Author

@yurishkuro

Why not define the binary format using protobuf IDL instead of inventing some custom encoding?

I got a recommendation to not define it as protobuf as it's proprietary protocol/tech. That's said proposed format is basically how it will look in protobuf.

@yurishkuro
Copy link
Member

I got a recommendation to not define it as protobuf as it's proprietary protocol/tech. That's said proposed format is basically how it will look in protobuf.

You just got another recommendation :-) Should we have a vote then?

There are many binary format specs out there. I think it would be best if we pick one rather than come up with a custom n+1 spec. There's nothing wrong with having the format defined by a widely used spec imo, it does not force the implementation in any way.

@SergeyKanzhelev
Copy link
Member Author

You just got another recommendation :-) Should we have a vote then?

Before voting - do you agree that we should provide binary encoding rules that basically copies proto algorithm as not everybody can take dependency on proto?

Also I tried to do it with proto and it feels like an overkill. For instance, instead of byte length that is easy to read we will get varint with complex algorithm of serializing/deserializing.

What other binary format specs you can suggest?

@SergeyKanzhelev
Copy link
Member Author

PR was moved

This PR was moved here: w3c/trace-context-binary#2

@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/binary branch August 5, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants