Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if keys exist before trying to access them #417

Merged
merged 1 commit into from
Aug 20, 2020
Merged

Check if keys exist before trying to access them #417

merged 1 commit into from
Aug 20, 2020

Conversation

srjames90
Copy link
Contributor

@srjames90 srjames90 commented Jul 28, 2020 •
edited by SergeyKanzhelev
Loading

Fixes #416

@srjames90 srjames90 mentioned this pull request Jul 28, 2020
Closed
@dyladan dyladan requested a review from reyang July 28, 2020 20:40
reyang
reyang approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@SergeyKanzhelev
Copy link
Member

Marked as non substantive for IPR from ash-nazg.

@mtwo mtwo merged commit 387a108 into w3c:master Aug 20, 2020
@srjames90 srjames90 deleted the fix-key-errors branch August 20, 2020 21:23
@jaffinito jaffinito mentioned this pull request Aug 28, 2020
Merged
@bizob2828 bizob2828 mentioned this pull request Oct 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtwo mtwo mtwo approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@SergeyKanzhelev SergeyKanzhelev SergeyKanzhelev approved these changes

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix key errors in test suite
5 participants
@srjames90 @SergeyKanzhelev @mtwo @bogdandrutu @reyang