Add test case for random flag propagation #500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalyanaj
reviewed
Oct 11, 2022
dyladan
force-pushed
the
test-random-flag
branch
from
4f778c6
to
ad65cf3
Compare
dyladan
force-pushed
the
test-random-flag
branch
from
ad65cf3
to
f75750d
Compare
kalyanaj
approved these changes
Oct 11, 2022
basti1302
approved these changes
Oct 12, 2022
dyladan
commented
Oct 12, 2022
3 tasks
reyang
reviewed
Nov 23, 2022
| @@ -892,15 +920,35 @@ def test_multiple_requests_with_illegal_traceparent(self): | |||
| HARNESS_BIND_PORT the port which the test harness binds to (default to HARNESS_PORT) | |||
| SERVICE_ENDPOINT your test service endpoint (no default value) | |||
| STRICT_LEVEL the level of test strictness (default 2) | |||
| SPEC_LEVEL the minimum version of the Trace Context specification being tested (default 1) | |||
There was a problem hiding this comment.
Minor: consider SPEC_VERSION instead of SPEC_LEVEL?
reyang
reviewed
Nov 23, 2022
| @@ -79,12 +79,30 @@ Content-Type: application/json | |||
| HARNESS_BIND_HOST the host/address which the test harness binds to (default to HARNESS_HOST) | |||
| HARNESS_BIND_PORT the port which the test harness binds to (default to HARNESS_PORT) | |||
| SERVICE_ENDPOINT your test service endpoint (no default value) | |||
| STRICT_LEVEL the level of test strictness (default 2) | |||
| SPEC_LEVEL the minimum version of the Trace Context specification being tested (default 2) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a test case which asserts that the random flag is propagated. It only runs if the newly added SPEC_LEVEL variable is 2 or greater (default 2).